Skip to content

[IMPROVE] Replace Site_Name and Site_Url config name #22106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dougfabris wants to merge 1 commit into from
Closed

[IMPROVE] Replace Site_Name and Site_Url config name #22106

dougfabris wants to merge 1 commit into from

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented May 21, 2021

Proposed changes (including videos or screenshots)

image
image

Issue(s)

Steps to test or reproduce

  • Go to Admin > General
  • Check the new labels Workspace URL and Workspace Name instead of Site URL and Site Name

Further comments

@dougfabris dougfabris requested review from a team May 21, 2021 15:17
sampaiodiego
sampaiodiego requested changes May 21, 2021
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geekgonecrazy how this affects Cloud? I'm wondering if we can keep the setting name but change only the label.

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented May 21, 2021 •
edited
Loading

Yeah I think us and a few deployment methods. Alternatively could just take and if those are set via environment variable drop them into new setting? At least in interm?

That would give us a bit of time to switch.

@KevLehman KevLehman mentioned this pull request May 25, 2021
Closed
@murtaza98
Copy link
Contributor

murtaza98 commented May 26, 2021

FYI: Some of the omnichannel apps are also accessing the Site_Url setting value. Any suggestions on how to handle this without publishing a new version of the app?

@dougfabris
Copy link
Member Author

dougfabris commented May 26, 2021

@murtaza98 we are checking a way to change just the label as @sampaiodiego suggested

@sampaiodiego
Copy link
Member

sampaiodiego commented May 26, 2021 •
edited
Loading

thanks @dougfabris .. thinking more about this, I realized that we should consider changing a setting name/id as a breaking change.

I think having this definition will help us making the decision whether we should change it or not.

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

dougfabris seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dougfabris dougfabris closed this Jul 13, 2023
@tassoevan tassoevan deleted the improve/site-to-workspace branch August 4, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dougfabris @geekgonecrazy @murtaza98 @sampaiodiego @CLAassistant